search

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.
1.48k stars 261 forks source link

adapt for symfony 4.1 i18n routes #334

Closed alexanza closed 5 years ago

alexanza commented 6 years ago

I adapted the code to work with the i18n routes of symfony 4.1, I hope I did it correctly

jsncrdnl commented 5 years ago

+1

gobolabs commented 5 years ago

+1

tobias-93 commented 5 years ago

Looking good to me. Anyone with localized routes already tried this?

lordjancso commented 5 years ago

Is this will be merged?

tobias-93 commented 5 years ago

@lordjancso I asked whether it is working since I have no project using localized routes (yet). Nobody answered so I see no reason to merge right now. In case it is tested and working I will merge it.

lordjancso commented 5 years ago

@alexanza Please, pull the newest version to your code, then I will test it.

alexanza commented 5 years ago

@lordjancso done ;)

lordjancso commented 5 years ago

It is tested and works very well! :+1:

wickedOne commented 5 years ago

yes, we've been using this feature branch for a while now in one of our applications and works like a charm!

tobias-93 commented 5 years ago

Thanks, good work @alexanza!