Fix Deprecated : routing controller with single colon

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.

1.48k stars 261 forks source link

Fix Deprecated : routing controller with single colon #341

Closed ricostone closed 5 years ago

ricostone commented 5 years ago

Added :: instead of : for indexAction controller since it is deprecated from Symfony 4.1

tobias-93 commented 5 years ago

See #325, #327, #332 and #335, not the right solution.

stof commented 5 years ago

this deprecation has been reverted in Symfony (to be re-added in a future 5.x release), precisely because the migration path for shared bundles was not good otherwise (forcing to drop support for the LTS or to get the deprecation) while the code dealing with in in Symfony was quite simple.

the solution is to upgrade to Symfony 4.1.8

ricostone commented 5 years ago

Thanks for the feedback ! Sorry for duplicate PR ...

althaus commented 5 years ago

the solution is to upgrade to Symfony 4.1.8

The deprecation is thrown on the fresh 4.2?