search

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.
1.48k stars 261 forks source link

add support for symfony v5 #364

Closed ad3n closed 4 years ago

ad3n commented 4 years ago

add support for symfony v5

shinyvision commented 4 years ago

I think FOS\JsRoutingBundle\Command\RouterDebugExposedCommand:execute should return an exit code as seen in the travis jobs and apparently the PHPUnit framework expects return type declarations now.

I would fix these, but I don't think it's possible to add anything to your PR. Really interested in having things up to date with Symfony 5 though :D

Cryde commented 4 years ago

It's would be nice to have this bundle in SF5 :pray:

kl3sk commented 4 years ago

@rachel-fizz maybe do your own PR ?

shinyvision commented 4 years ago

@rachel-fizz maybe do your own PR ?

Sure! I'll take a look later today. Was hoping on @ad3n to make some modifications in the past couple of days :p

kl3sk commented 4 years ago

If you know how to, do your own. It will be way faster because of your activity 😉. And all the community will thank you 👐

shinyvision commented 4 years ago

To quote my fellow Dutch people: Hoppa!

tobias-93 commented 4 years ago

Closed in favour of #366