Fixed issue with creating absolute instead of relative path

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.

1.48k stars 261 forks source link

Fixed issue with creating absolute instead of relative path #391

Closed dew326 closed 4 years ago

dew326 commented 4 years ago

Fixed issue https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/issues/384

Turns out, the check if the host contains a port cannot be done in one place. Each case has to check port on different base host or this.getHost().

dmaicher commented 4 years ago

@dew326 I can confirm that this fixes my issue https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/issues/384.

Thanks a lot for the fast fix :+1: :rocket:

dew326 commented 4 years ago

Hi @tobias-93, could you take a look?

tobias-93 commented 4 years ago

Hi @dew326, thanks for the contribution! Hopefully this solves all host+port issues, but if any pops up let me know.

lampelk commented 2 years ago

Has this fixed been released? I am having this issue with v3.1.1...

tobias-93 commented 2 years ago

Hi @Lampelk,

Sorry you're experiencing issues. This PR has been merged and released a long time ago, so I doubt you have the same issue. Please make a Github issue with a description of your problem so we can have a look.

Regards, Tobias