search

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.
1.48k stars 261 forks source link

Support Symfony 7 #470

Closed tacman closed 9 months ago

tacman commented 10 months ago

Symfony 7 will be out in a few days. It would be great if the bundle could be installed when using it.

tacman commented 10 months ago

Symfony 7 is out.

Problem 2
    - Root composer.json requires friendsofsymfony/jsrouting-bundle ^3.3 -> satisfiable by friendsofsymfony/jsrouting-bundle[3.3.0].
    - friendsofsymfony/jsrouting-bundle 3.3.0 requires symfony/framework-bundle ^5.4|^6.0 -> found symfony/framework-bundle[v5.4.0, ..., v5.4.32, v6.0.0, ..., v6.4.0] but these were not loaded, likely because it conflicts with another require.

I can submit a PR, but what do you think of bumping the requirements to only supported versions of Symfony? That is

image

tacman commented 10 months ago

I see there's a push to the master branch, can you create a new release please?

tobias-93 commented 10 months ago

My plan was to release it simultaneously with #464, since there were also some requests for that. For now you could use dev-master@dev in your Composer constraints.

By the way: why the hurry in updating to SF7.0? Feature-wise 6.4 and 7.0 are the same, and 6.4 is LTS...

tacman commented 10 months ago

No real rush, I'm making sure all of my bundles work with Symfony 7, and the most important one (a dynamic grid bundle) depends on this bundle, so it's mostly for my testing purposes.

And there's the coolness factor, right? Nothing says "hip" like having a working app with Symfony 7, in my own geeky mind. ;-)

On Thu, Nov 30, 2023 at 8:00 AM Tobias Feijten @.***> wrote:

My plan was to release it simultaneously with #464 https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/464, since there were also some requests for that. For now you could use @.*** in your Composer constraints.

By the way: why the hurry in updating to SF7.0? Feature-wise 6.4 and 7.0 are the same, and 6.4 is LTS...

— Reply to this email directly, view it on GitHub https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/issues/470#issuecomment-1833742892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQNJDSQ3VR25MP7RRR3YHB7NBAVCNFSM6AAAAAA754DFGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTG42DEOBZGI . You are receiving this because you authored the thread.Message ID: @.***>

tacman commented 10 months ago

Any downside to releasing a version that works with Version 7, and another one when #464 is fixed?

tobias-93 commented 9 months ago

Update has been released with version 3.4.0 🎉