search

FriendsOfSymfony / FOSMessageBundle

User-to-user messaging bundle for Symfony
356 stars 183 forks source link

Fixing SF4.3+ deprecation notice for `TreeBuilder` #348

Closed emulienfou closed 2 years ago

emulienfou commented 5 years ago

Fixing Symfony 4.3+ about Symfony\Component\Config\Definition\Builder\TreeBuilder deprecation notice, using method getRootNode() instead of root() method.

hex333ham commented 5 years ago

@emulienfou Travis checks have failed due to deprecation notices and potentially changes to travis platform

I'll look into this later

TeLiXj commented 4 years ago

any update of this?? I only have to solve this deprecation to update to Symfony 5.0 thanks!

hex333ham commented 4 years ago

@TeLiXj not yet, unfortunately, I've not had time at all to fix Travis for testing due to being in the middle of a product launch

the best thing to do right now is to configure composer to use this PR/branch or fork the repo with your changes until this can be resolved

encreinformatique commented 4 years ago

It seems the PHP 5.5 not found can be resolved with dist: trusty into the travis.yml file.

See https://travis-ci.community/t/php-5-4-and-5-5-archives-missing/3723/4

hex333ham commented 4 years ago

@encreinformatique ace, that makes things alot easier, I'll take a look at it this week

changed dist and I'm running a Travis check now in a separate PR, you can track it here - https://github.com/FriendsOfSymfony/FOSMessageBundle/pull/352

I'll eventually merge all these prs into the lts-support branch

colonelclick commented 3 years ago

Is there anything any of us can do to help this forward? Thank you.

hex333ham commented 3 years ago

@colonelclick not really, recommend you use eric's fork in the meantime, I am completely swamped right now and likely will be till the end of the month, this will get merged as soon as I can dedicate time to work out where it goes in the git workflow - https://github.com/FriendsOfSymfony/FOSMessageBundle/pull/360