search

FriendsOfSymfony / FOSOAuthServerBundle

A server side OAuth2 Bundle for Symfony
1.09k stars 451 forks source link

[Symfony v4.3] Templating is deprecated, use Twig instead #623

Closed karser closed 3 years ago

karser commented 5 years ago

Hello, Templating component is deprecated in Symfony 4.3. This PR makes this bundle to use Twig directly.

Which is correct branch for this PR, master or v1.6? What's happening to PHPStan in master? It finds 139 errors, although they were fixed up to lvl 6 last year https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/pull/573

armandabric commented 5 years ago

Related to https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/issues/616

miguelbemartin commented 5 years ago

Is anyone maintaining this bundle?

karser commented 5 years ago

I was going to fix phpstan regressions in a separate PR, but I guess it's not a blocker to merge this PR, is it? @alcaeus @dkarlovi

alcaeus commented 5 years ago

@miguelbemartin yes, @dkarlovi and I are trying to. I needed some time to settle into my new job, but I'm planning to devote some more time over the next few days to cleaning up the tracker some more and start merging PRs.

However, Open Source isn't done by maintainers. Anyone can help, by highlighting issues that can be closed because they are solved or no longer relevant, by trying to reproduce an issue, or by reviewing a pull request and leaving their comments on it. Not only is it helpful for the health of the project, but it's a great learning experience for all parties involved!

blackarcanis commented 4 years ago

Any updates to merge this ? Thank you !

Ioni14 commented 4 years ago

Any news?

deguif commented 3 years ago

@karser would you mind rebasing this PR?

deguif commented 3 years ago

Closing as it was done in https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/pull/653