[WIP] Fix master build - Githubissues

FriendsOfSymfony / FOSOAuthServerBundle

A server side OAuth2 Bundle for Symfony

1.09k stars 451 forks source link

[WIP] Fix master build #624

Closed alcaeus closed 4 years ago

alcaeus commented 5 years ago

This PR aims to fix current build failures in the master build. Current changes

Change travis build pipeline to run PHPUnit, php-cs-fixer and phpstan in separate build steps
Update to PHPUnit 7.5
Use bundled phpstan version for better control of what version we're using
Fix errors reported by php-cs-fixer

Note that fixing phpstan errors is still ongoing. There are quite a few inconsistencies between docs and code, so we'll have to investigate those in more detail.

geoffrey-brier commented 5 years ago

Hi @alcaeus Need a hand on this one ?

alcaeus commented 4 years ago

Hi @geoffrey-brier! @dkarlovi wanted to take a look at the PR, as I can't quite figure out why PHPStan started failing. Before giving this a shot, please check with @dkarlovi to see how far they've gotten. Thanks for the offer!

dkarlovi commented 4 years ago

Fixed in https://github.com/alcaeus/FOSOAuthServerBundle/pull/1