FriendsOfSymfony / FOSRestBundle

This Bundle provides various tools to rapidly develop RESTful API's with Symfony
http://symfony.com/doc/master/bundles/FOSRestBundle/index.html
MIT License
2.79k stars 703 forks source link

New release? #2111

Closed enumag closed 4 years ago

enumag commented 4 years ago

I'm trying to upgrade my project to Symfony 4.4 LTS. However even with the latest release of this bundle I'm getting this deprecation:

  1x: The "controller_name_converter" service is deprecated since Symfony 4.3. It is being referenced by the "fos_rest.routing.loader.controller" service.

I see this was already fixed in master. When can we expect a release?

xabbuh commented 4 years ago

You can try 2.8@dev for now and disable the controller name parser like this:

fos_rest:
    routing_loader:
        parse_controller_name: false
xabbuh commented 4 years ago

@enumag Can you confirm that the deprecation is gone when using 2.8?

enumag commented 4 years ago

With 2.8@dev plus the configuration you mentioned, I can confirm that the deprecation notice is indeed gone. There were some other deprecations so I ended up adding all of this:

fos_rest:
    view:
        default_engine: ~
        force_redirects: []
    exception:
        exception_controller: fos_rest.exception.controller::showAction
    routing_loader:
        parse_controller_name: false
    service:
        templating: ~
gisostallenberg commented 4 years ago

@xabbuh Is there a fixed release path? The changes between 2.7 and 3.0-dev allow installing the bundle in a Symfony 5 application. When will this be released?

pajasry commented 4 years ago

There is no date. But it is in work. I waiting for it too. Try downgrade to symfony 4.4

enumag commented 4 years ago

@pajasry Funny that this package is actually the last one preventing me from upgrading to Symfony 4 (really 4, not 5) because of the deprecations which cause my CI to fail.

michaljusiega commented 4 years ago

Symfony 6 will come out faster than the compatibility of this library for Symfony 5 :D

dbrumann commented 4 years ago

@michaljusiega you are free to spend some of your time helping speed up the process, this is open source after all.

xabbuh commented 4 years ago

You can now test your applications using the 2.8.0-beta1 tag (please do so and report any issues you experience 🙇). Opt-in for beta releases like this in your composer.json file for example:

{
    "require": {
        "friendsofsymfony/rest-bundle": "^2.8@beta"
    }
}