search

FriendsOfSymfony / FOSRestBundle

This Bundle provides various tools to rapidly develop RESTful API's with Symfony
http://symfony.com/doc/master/bundles/FOSRestBundle/index.html
MIT License
2.79k stars 704 forks source link

use stable PHP 8 releases in the CI #2278

Closed xabbuh closed 3 years ago

GuilhemN commented 3 years ago

I pushed some commits to your branch, I hope you don't mind.

I upgraded the code to phpunit 9 as it's the only version supporting php 8. The ignore requirements is back due to JMS\serializer. There are some failures remaining, I'm not sure yet where do they come from, they may be related to some changes in php 8.

GuilhemN commented 3 years ago

Wow the battle was tough... But I won against phpunit and php 8 :D

This is ready for me, I can also do the merge in 3.x if you want.

DenchikBY commented 3 years ago

Hi, do you plan rework annotations in this PR to support php 8 format?

xabbuh commented 3 years ago

If you are talking about support for PHP 8 attributes, that's not in the scope of this PR. But if you are interested in giving it a try, please feel free to open a separate pull request.

kevinpapst commented 3 years ago

Can we help to push this PR and the upcoming release that will include it?

GuilhemN commented 3 years ago

Oops sorry I just realized this PR was also targetting 2.x and I could have completed it instead of pushing to https://github.com/FriendsOfSymfony/FOSRestBundle/pull/2280... I guess I wasn't well awaken when I did that :x

Anyway it's merged now so too late I suppose... I'm closing this PR in favor of https://github.com/FriendsOfSymfony/FOSRestBundle/pull/2280 :)