search

FriendsOfSymfony / FOSRestBundle

This Bundle provides various tools to rapidly develop RESTful API's with Symfony
http://symfony.com/doc/master/bundles/FOSRestBundle/index.html
MIT License
2.79k stars 703 forks source link

Enable usage of the bundle without Twig #2320

Closed Th3Mouk closed 2 years ago

Th3Mouk commented 3 years ago

As I made a fork, and following https://github.com/FriendsOfSymfony/FOSRestBundle/issues/1812#issuecomment-893277145, I open this PR which will evolve according to the feedbacks

GuilhemN commented 3 years ago

Indeed since https://github.com/FriendsOfSymfony/FOSRestBundle/commit/73f0dfd6dde7bac0d399dd536805c404eb2f744d#diff-2359bb4681ba7bf807bf836fd67da56e5983f70efdc2bcca29768026d4c2352c removed support of templating I think we can now safely remove this condition to have twig installed. So 👍🏻 for me.

W0rma commented 3 years ago

@Th3Mouk Should the dev dependency symfony/twig-bundle and all its usages in the tests be removed to check if the tests will still pass (https://github.com/FriendsOfSymfony/FOSRestBundle/blob/3.x/composer.json#L56)?

Th3Mouk commented 3 years ago

@W0rma I didn't find any occurence with use (.*)?Twig(.*)?; so this dependency seems no longer needed

goetas commented 2 years ago

thank you