search

FriendsOfSymfony / FOSRestBundle

This Bundle provides various tools to rapidly develop RESTful API's with Symfony
http://symfony.com/doc/master/bundles/FOSRestBundle/index.html
MIT License
2.79k stars 707 forks source link

Add Symfony 6 support #2340

Closed mbabker closed 2 years ago

mbabker commented 2 years ago

Replaces #2330 Resolves #2332 Fixes #2334 Includes #2341

This will drop support for Symfony 5.0 thru 5.2, since these branches are already past their end of support dates this shouldn't be a huge issue.

W0rma commented 2 years ago

@mbabker Thank you very much for working on this!

I have submitted #2341 which should fix the BC layer of the Route annotation for symfony 6.

W0rma commented 2 years ago

@mbabker Feel free to cherry-pick my commit from https://github.com/FriendsOfSymfony/FOSRestBundle/pull/2341

goetas commented 2 years ago

Does anyone of you have an idea why https://github.com/FriendsOfSymfony/FOSRestBundle/runs/4215121790?check_suite_focus=true is failing?

mbabker commented 2 years ago

PHP-CS-Fixer doesn’t support SF 6 yet, https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6095

Adding a composer remove step would get around that one

W0rma commented 2 years ago

@mbabker I prepared https://github.com/mbabker/FOSRestBundle/pull/2 which should fix the symfony 6 pipeline.

See https://github.com/W0rma/FOSRestBundle/actions/runs/1475592791

The pipelines for symfony 5.4 and 6.0 only show some deprecation warnings triggered by vendor packages.

goetas commented 2 years ago

this to me looks good. do you have anyting against waiting for the symfony 6 release or you think that is better to merge it earlier?

mbabker commented 2 years ago

Should be good to land now. Plus, for that small handful of folks who might actually be beta testing 5.4 or 6.0, having this bundle be ready to use would help enable that.

goetas commented 2 years ago

thanks everyone for your work! :tada: