Using plural name in route with single name in the action

[AyhamAlzoubi]

Hey I am using FostRestBundle with Symfony2

I want to use the route /users/{id} with methods PUT, POST, DELETE

I have the actions:

deleteUsersAction($id)
postUsersAction($request)
putUserAction($id)

can't we have it as: deleteUserAction($id) with the same route /users/{id} because it makes sense to have one user has this $id

this works only for PUT but not for POST and DELETE ?

[lsmith77]

i think the relevant code is somewhere around here: https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Routing/Loader/Reader/RestActionReader.php#L410

though i guess such changes may then require a BC flag to prevent code from breaking

[AyhamAlzoubi]

Here I am pluralizing the route in any case and seems fine Can you have a look please?

https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Routing/Loader/Reader/RestActionReader.php#L410

// if we have argument for current resource, then it's object.
            // otherwise - it's collection
            if (isset($arguments[$i])) {
                if (null !== $resource) {
                    $urlParts[] =
                        strtolower($this->inflector->pluralize($resource))
                        .'/{'.$arguments[$i]->getName().'}';
                } else {
                    $urlParts[] = '{'.$arguments[$i]->getName().'}';
                }
            } elseif (null !== $resource) {
                $urlParts[] = $this->inflector->pluralize(strtolower($resource));
            }

[odino]

To integrate:

• this lets you write routes like postCustomerAction, and it seems that postCustomersAction will still work ( @lsmith77 didnt test it throughly though )
• route will still be POST /customers

This way we can provide consistency to the routing and to the action naming, even though Im not sure if there is any unhandled special case @AyhamAlzoubi is forgetting about...

[AyhamAlzoubi]

failing cases:

• We have the case where the action name is single and the route is single, then after this change the route will plural and the old route won't be found in this case we need to generate both routes the single and the plural
• and the case when we generate route for action contains more than keyword, this will make them all plural as /customers/passwords/...

[lsmith77]

i suggest you open a PR with any changes ..

[lsmith77]

ping

[Tobion]

Closing as automatic route generation is deprecated: #1954