search

FriendsOfSymfony / FOSTwitterBundle

UNMAINTAINED. Please use HWIOAuthBundle as a replacement for FOSTwitterBundle.
http://friendsofsymfony.github.com/
145 stars 38 forks source link

small changes #45

Open bamarni opened 11 years ago

stof commented 11 years ago

Can you also modify the .travis.yml file to test with current Symfony instead of 2.0 ?

lemoinem commented 11 years ago

Any news regarding this? Would be nice to have the package work out of the box...

stof commented 11 years ago

my opinion is to officially deprecate this bundle as most of its code is about features dropped by Twitter anyway. The only remaining feature in the bundle is the OAuth 1 integration, and HWIOAuthBundle is a better choice for it IMO.

arghav commented 11 years ago

I agree with @stof, it doesn't make much sense to maintain this bundle anymore when HWIOAuthBundle pretty much does the same thing.

That said, right now I do not have the time to maintain the repo kertz/twitteroauth. If anyone is ready to maintain it I can transfer the ownership. Possibly to FOS itself if it makes sense.

lemoinem commented 11 years ago

Well, In my case, I just need access to the Twitter API (Not really the sign-in with twitter, yet)... In respect to this, themattharris/tmhOAuth seems to be a bit more up-to-date (e.g. at least support streaming API which seems fairly recent). And seems easy enough to use.

As far as I can see, HWIOAuthBundle doesn't provide access to the Twitter API (nor is it even remotely close to its goal).

Do you think it would be a good idea to simply provide a new version of this Bundle which would be a wrapper around tmhOAuth so we can have an easy to use bundle providing access to the Twitter API (Just like FOSFacebook does with the Facebook PHP SDK ?)

stof commented 11 years ago

@kertz I don't think it makes sense to transfer it to FOS. We already don't have enough time to maintain the current set of repos. and once this bundle get deprecated officially in favor of HWIOAuthBundle, the FOS bundles will not depend on the library anymore. Thus, AFAIK, none of the FOS devs is using the FOSTwitterBundle currently (which is also one of the reason why it looks abandoned already)

@lemoinem If you want to access the API on your own behalf, FOSTwitterBundle is not close either. If you want to access the API on behalf of your user, you need 2 different things: first authenticating through OAuth (which is what HWIOAuthBundle and FOSTwitterBundle are doing) and then using the retrieved access token in an API client. I don't think it makes sense to create a bundle doing only $apiClient->setToken($hwiToken->getAccessToken()). And regarding the comparison with FOSFacebookBundle, my own preference would be to deprecate FOSFacebookBundle as well. Currently, it implements the OAuth2 auth through the Facebook SDK, which is a huge piece of crap (actually, the bundle had to rewrote 2/3 of the code to be able to use the Symfony Session system) and is the reason of most bugs reported on it. Thus, the implementation of HWIOauthBundle is more efficient, not only cleaner. So if I had to do some Facebook API calls on behalf of a user (I really hope I won't), I would still do it by using HWIOAuthBundle for the auth part, as shown above.

lemoinem commented 11 years ago

Thanks @stof for the precision. After a couple of tests, FOSTwitter is most definitely not what I need... :+1: for deprecation then...