FriendsOfSymfony / FOSUserBundle

Provides user management for your Symfony project. Compatible with Doctrine ORM & ODM, and custom storages.
https://symfony.com/doc/master/bundles/FOSUserBundle/index.html
MIT License
3.25k stars 1.57k forks source link

Provide documentation for Symfony4 #2861

Open polishExperiment opened 5 years ago

polishExperiment commented 5 years ago

This is feature request.

Symfony 4.x

Currently there is no documentation for Symfony 4.

This issue is an attempt at fixing that.

polishExperiment commented 5 years ago

Could someone put me as an assignee? Could someone put a label Documentation or give me access to do that myself?

XWB commented 5 years ago

Feel free to open a pull request :)

alfonsodev commented 5 years ago

I've configured successfully the bundle in Symfony 4 the changes needed are

Clindbergh commented 5 years ago

Also required:

You've to add the following to the config/packages/framework.yaml:

framework:
    # ... other stuff ...

    templating:
        engines: ['twig', 'php']

Originally posted by @devtronic in https://github.com/FriendsOfSymfony/FOSUserBundle/issues/2870#issuecomment-441001037

alfonsodev commented 5 years ago

Right now the Official Symfony website is displaying this warning, image

One suggestion @XWB, I think that we need to create a 4.x branch and then we can open a pull request with the updated documentation, master and 4.x can be the same, but I suspect that Symfony website convention is to read from version number branch to match their dropdown switcher for versions.
Also, it would be great to have a label for Symfony 4 to group all related issues, specially for newcomers.

Thanks you!

shakaran commented 5 years ago

@XWB any update with this? Could you create the branch 4.x as suggested by @alfonsodev ?

tattali commented 4 years ago

Feel free to open a pull request :)

https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2885

TangMonk commented 4 years ago

It is really necessary for Symfony 4