Add Symfony 5.4 compatibility for version 2.x with groups

FriendsOfSymfony / FOSUserBundle

Provides user management for your Symfony project. Compatible with Doctrine ORM & ODM, and custom storages.

https://symfony.com/doc/master/bundles/FOSUserBundle/index.html

MIT License

3.25k stars 1.57k forks source link

Add Symfony 5.4 compatibility for version 2.x with groups #3046

Closed andreclemente closed 1 year ago

andreclemente commented 1 year ago

This pull request aims to keep the deprecated groups feature on this dependency and, at the same time, be able to upgrade the Symfony framework to version 5.4.

stof commented 1 year ago

This cannot be merged into 3.x. Those changes are breaking BC.

andreclemente commented 1 year ago

That's why the pull request is for 2.x...

stof commented 1 year ago

sorry, I meant for 2.x in my comment. The 2.x branch is not allowed to break BC compared to the existing 2.2.4 release.

stof commented 1 year ago

I'm closing this as it cannot be accepted. There is no way to add support for Symfony 5.4 in the 2.x branch without BC breaks (I tried that approach before doing a 3.0 release).

andreclemente commented 8 months ago

Can you describe the errors you get? It works on my side...