FriendsOfSymfony / friendsofsymfony.github.io

Description of what FriendsOfSymfony (aka FoS) is about.
http://friendsofsymfony.github.io
32 stars 4 forks source link

Adopt NotificationBundle into FOS #20

Closed merk closed 11 years ago

merk commented 13 years ago

I've been working on a proof of concept bundle for allowing bundles to notify users that something has occurred that the user might be interested in.

Ultimately, support for notification by many different means like Email, Twitter, SMS, IRC could be supported, along with the ability to offload notifications to a message queue of some kind.

There are a few projects around that will end up needing such functionality, and I'd like to see this bundle adopted by the FOS group to give it a bit more exposure (and I think you'll all need it at some point ;))

I'm open to any feedback or suggestions. This is a proof of concept.

https://github.com/merk/merkNotificationBundle

lsmith77 commented 13 years ago

Will need to review in more detail: 1) for the twig support, couldnt we reuse flash messages here (though we probably all agree that the flash message system in core could get some tweaks) 2) for persistence we should also support ODM 3) in the example in the README i dont understand $user = $object->getOwner(), isnt the user already set in the $actor?

merk commented 13 years ago

1) I'll take someone elses lead on the architecture of this bit, I dont follow all the complexities of flash messages

2) I havent written the ODM part yet, I'd prefer to get some feedback first before diving in to that (reducing the need to change things twice)

3) There are 2 users associated with a notification, an actor and a target. The actor is who caused the action to occur ('merk replied to your message'), the owner owns the object that was acted upon (your message).

lsmith77 commented 13 years ago

Still havent had time to review, but I am still quite sympathetic to the proposal. Kinda surprised no one else has commented.

Bacteries commented 13 years ago

Love the idea and think lot of projects need something like that.

dbu commented 13 years ago

this sounds very useful to me. i am no member of the FriendsOfSymfony so i can't vote to adopt it (but i would vote yes :-)

i think additional interesting points would be:

stof commented 13 years ago

+1 for inclusion

henrikbjorn commented 13 years ago

If this should be included it should be be modelled after the http://activitystrea.ms/ specification.

merk commented 13 years ago

@IamPersistent mentioned that to me when we were talking about his pull request. It makes sense to do follow that specification - I'll spend some time this week working to see what needs to be done to support it..

dbu commented 11 years ago

ping

stof commented 11 years ago

@dbu The bundle has not been updated at all since more than 1 year, so :-1:

merk commented 11 years ago

Yeah, im not in favour of doing anything here - I've not had any time at all to dedicate to this bundle (and it is still just a prototype).