Create Symfony HTTP Cache repository.

[dantleech]

Hi

We have been discussing (at FOSHttpCache) the creation of a repository dedicated to extending the Symfony HTTP cache.

Currently the FOSHttpCache can add the following features to the Symfony HttpCache:

• An event dispatching trait for the HTTP cache.
• Setting a Custom TTL
• Adding Debug headers
• Purge support
• User context support

We now want to also add tag invalidation capabilities and it occurs to us that this is outside of the scope of the FOSHttpCache (which provides an abstraction to third-party cache servers) and also that all of these features can be used without the infrastructure of the FOSHttpCache component.

So I would like to propose the creation of a FOSSymfonyHttpCache repository (or alternatively FOSHttpKernelCache, or anything suitable).

[dbu]

:+1:

as maintainer of FOSHttpCache i support this idea. we are preparing for a version 2 of FOSHttpCache, this would be a good oportunity to split out this part of the package which is becoming too large and dilluting the focus of the FOSHttpCache library.

[dantleech]

ping

[GuilhemN]

👍 I think we should split our repositories more often when they become too large.

[stof]

:+1: for splitting the library to keep the scope maintainable

[dbu]

i heard no doubts or downvotes. it seems i have the rights to create that repository. ok if i create FOSSymfonyHttpCache now? @dantleech are you still up to lead this effort?

[dantleech]

Do we still want to do it; I was under the impression that Symfony 3.0 will support tag invalidation natively?

On Fri, Jul 01, 2016 at 06:07:00AM -0700, David Buchmann wrote:

i heard no doubts or downvotes. it seems i have the rights to create that repository. ok if i create FOSSymfonyHttpCache now? [1]@dantleech are you still up to lead that?

— You are receiving this because you were mentioned. Reply to this email directly, [2]view it on GitHub, or [3]mute the thread.

Reverse link: [4]unknown

References

Visible links

1. https://github.com/dantleech
2. https://github.com/FriendsOfSymfony/friendsofsymfony.github.com/issues/57#issuecomment-229941654
3. https://github.com/notifications/unsubscribe/AAgZcd-O_QQPZ5y2zCX3uRsAZomTmbUjks5qRRD0gaJpZM4IC7sB
4. https://github.com/FriendsOfSymfony/friendsofsymfony.github.com/issues/57#issuecomment-229941654

[dbu]

that was a confusion i created. symfony added a caching component that among other things supports tagging. HttpCache does not use that component yet. but indeed, maybe we better try to contribute to symfony itself to make HttpCache use the caching component to get tag invalidation support into it.

[dbu]

@dantleech i am trying to wrap up FOSHttpCache 2.0 - what about the topic of splitting out the symfony HTTP cache implementation into its own repository? do you want to do it? if you don't i guess i will keep it in FOSHttpCache for 2.0 and we can see about removing it in 3.0

[dantleech]

I suppose the least we could do is spiit it out without modifying the code, create/move the documentation and tag it as 1.0, not sure if I have time to add the tag functionality or otherwise work much on the code at this point.

[dbu]

that sounds like a plan. should we move both the reverse proxy and the proxy client? they do not directly depend on each other, but its likely easier to functional test when they are together. moving the client makes the coupling from the new repo to the FOSHttpCache rather strong, but imo thats ok and the base client needs to strictly keep BC anyways

[dbu]

FOSHttpCache contains the symfony reverse proxy extensions, and for tag support there is toflar/psr6-symfony-http-cache-store