Unused local variable and fixed wrong type of the parameter

FriendsOfSymfony1 / doctrine1

[DEPRECATED -- Use Doctrine2 instead] Doctrine 1 Object Relational Mapper.

http://www.doctrine-project.org

GNU Lesser General Public License v2.1

40 stars 75 forks source link

Closed miamibc closed 8 months ago

miamibc commented 9 months ago

Constant problem of projects with Symfony1 - wrong type string in phpdoc block for function Collection::fromArray() must be array

miamibc commented 8 months ago

You made me a quest from very very very dumb fix. Is it really necessary to split this into two commits?

thePanz commented 8 months ago

You made me a quest from very very very dumb fix. Is it really necessary to split this into two commits?

I feel like a clean way to proceed. I can prepared those two changes myself and set you as author.

Thanks for opening the PR!

miamibc commented 8 months ago

Thank you very much