Open mcgrogan91 opened 7 months ago
I'm not familiar enough with the internals of this package to build the test, but this behavior occurs when:
I began writing a test but couldn't get the test suite to run on my machine, and wasn't sure how to mock the change in PDO behavior from 7.x to 8.0
I do see the task behavior is fixed on a build pointing at my forks branch, help figuring out how to build the test for it would be appreciated
This patch will fix the issue #98.
I just remembered that I wrote a failing test. Look at #103.
I will cherry-pick your patch and run the test.
@mcgrogan91 Yes, the patch you provide works. :100:
Sadly, the current CI does not support its execution as missing a MySQL server.
How I executed the test suite?
tests/bin/test
, expect failing test.tests/bin/test
, expect test pass.I'm glad to hear your testing of it worked. What's the next step to get this moving? Right now we have our application pointing at my fork but i'd love to get us back onto the main repository before moving forward with a production deploy
Any update on this? Any chance of merging this PR?
Addresses an issue reported in https://github.com/FriendsOfSymfony1/doctrine1/issues/130