FriendsOfSymfony1 / doctrine1

[DEPRECATED -- Use Doctrine2 instead] Doctrine 1 Object Relational Mapper.
http://www.doctrine-project.org
GNU Lesser General Public License v2.1
40 stars 75 forks source link

Update the export command to use a PHP8-safe PDO transaction commit path #131

Open mcgrogan91 opened 7 months ago

mcgrogan91 commented 7 months ago

Addresses an issue reported in https://github.com/FriendsOfSymfony1/doctrine1/issues/130

mcgrogan91 commented 7 months ago

I'm not familiar enough with the internals of this package to build the test, but this behavior occurs when:

I began writing a test but couldn't get the test suite to run on my machine, and wasn't sure how to mock the change in PDO behavior from 7.x to 8.0

I do see the task behavior is fixed on a build pointing at my forks branch, help figuring out how to build the test for it would be appreciated

alquerci commented 7 months ago

This patch will fix the issue #98.

I just remembered that I wrote a failing test. Look at #103.

I will cherry-pick your patch and run the test.

alquerci commented 7 months ago

@mcgrogan91 Yes, the patch you provide works. :100:


Sadly, the current CI does not support its execution as missing a MySQL server.

How I executed the test suite?

  1. Checkout on #103 where two commits of this PR applied
  2. Merge #90
  3. Revert two commits of this PR
  4. Run tests suite tests/bin/test, expect failing test.
  5. Apply two commits of this PR
  6. Run tests suite tests/bin/test, expect test pass.
mcgrogan91 commented 6 months ago

I'm glad to hear your testing of it worked. What's the next step to get this moving? Right now we have our application pointing at my fork but i'd love to get us back onto the main repository before moving forward with a production deploy

szymone commented 4 months ago

Any update on this? Any chance of merging this PR?