If you make a fix for Oracle connection only do it ONLY for Oracle!

FriendsOfSymfony1 / doctrine1

[DEPRECATED -- Use Doctrine2 instead] Doctrine 1 Object Relational Mapper.

http://www.doctrine-project.org

GNU Lesser General Public License v2.1

40 stars 75 forks source link

If you make a fix for Oracle connection only do it ONLY for Oracle! #23

Closed MagicPush closed 8 years ago

MagicPush commented 8 years ago

Such a fix broke mysql queries which contained spaces before 'SELECT' (common situation when you format your code or make your query substring by substring).

j0k3r commented 8 years ago

You know, you can be less agressive in your commit message. It won't kill kittens.

MagicPush commented 8 years ago

My apologies. That ora-fix was... not so obvious and finally really frustrating in our circumstances. I'm really very happy about the fact you've merged my fix. And I like kittens. ^^