Fix tests to be able to finish it successfully

[alquerci]

What provides this patch?

• Activates tests execution
• Fix side effect of testConnectionInformationDecoded as it switch the current connection but never restore.

Status before this patch

PHP 5.3

• Doctrine_Record_Synchronize_TestCase

  • testSynchronizeAfterSaveRecord
  • testSynchronizeAfterAddRecord

  Issue: When the order is not explicit then you must not expect that relationships are ordered by the primary key.

• Search behavior regarding record generator

PHP > 5.3

• I18n and Search behavior regarding record generator

PHP 7

• Doctrine_Record_Filter_TestCase
  • testCompoundFilterSupportsAccessingRelatedComponentProperties

PHP all

• Doctrine_Ticket_1783_TestCase

  • testValidateLargeIntegers

• Doctrine_Query_MultiJoin_TestCase

  • testMultipleOneToManyFetching
  • testMultipleOneToManyFetching2

  Issue: When the order is not explicit then you must not expect that relationships are ordered by the primary key.

• Doctrine_Record_FromArray_TestCase

  • testFromArrayAfterSaveRecord

  Issue: When the order is not explicit then you must not expect that relationships are ordered by the primary key.

Status after this patch

All tests passes.

cc @j0k3r @GromNaN

[j0k3r]

Could you check why tests are failing? Thanks

[alquerci]

@j0k3r From the doctrine1 documentation:

It is not uncommon for the test suite to have fails that we are aware of. Often Doctrine will have test cases for bugs or enhancement requests that cannot be committed until later versions. Or we simply don’t have a fix for the issue yet and the test remains failing. You can ask on the mailing list or in IRC for how many fails should be expected in each version of Doctrine.

All its failures are currently know as failed. For sure we need to take time to fix them. I estimate in 4 pull request to fix them all.

As I see there is already one #31

[alquerci]

Hello @thePanz @mkopinsky

Can you take a look at this patch?

[thePanz]

@alquerci added a couple of comments, can you rebase your PR to the new repository fos1/doctrine1?

[alquerci]

@thePanz Code review fixed and the branch is rebased.

Also I add tests/tmp to .gitignore and finish to revert this commit 826bc9015c18200d6dd11177ef9b9a296991a31f.

[alquerci]

@thePanz What left to do on this PR in order to be merged?

Do we really need to fix all issues on it?

[thePanz]

@alquerci I merged some other PRs, can we try to rebase this and check the status again? Thank you for your patience :)

[alquerci]

@thePanz Rebased but it seems that it miss the Travis integration.

Until: https://travis-ci.org/alquerci/doctrine1/builds/519115319

[thePanz]

@alquerci TravisCI has been re-enabled, can you push again to trigger the CI to run? The first tests are green now (php 5.4 and php 5.5) for: https://travis-ci.org/FriendsOfSymfony1/doctrine1/builds/519309877

[alquerci]

The first tests are green now

Just because nothing as been executed. @thePanz Look at this one: https://travis-ci.org/FriendsOfSymfony1/doctrine1/builds/519393560

[thePanz]

@alquerci damn, saw them after writing that message

[alquerci]

Hello @thePanz

As you said me you took this PR. Did you done any progress or I can resume my work on it in order to have a green status ?

The goal will not to fix all failed test here where for some of there there will be mark as "known failed".

I will be able to work on it during week-ends.

[thePanz]

@alquerci unfortunately I had no more time to continue working on this. feel free to take over the MR

[alquerci]

@thePanz Thank you for your fast answer.

[alquerci]

@thePanz I fixed all issues and reach a green test.

[thePanz]

LGTM @alquerci , woudl you squash some of the commits to have a cleaner git history? wdyt?

[alquerci]

Ready to merge.

[thePanz]

Merged @alquerci (wow, 4 years and 1 month after opening it) :see_no_evil: