search

FriendsOfSymfony1 / doctrine1

[DEPRECATED -- Use Doctrine2 instead] Doctrine 1 Object Relational Mapper.
http://www.doctrine-project.org
GNU Lesser General Public License v2.1
40 stars 75 forks source link

Remove `create_function` call as it is deprecated in 7.3 #65

Closed desyncr closed 5 years ago

desyncr commented 5 years ago

Is there anything holding this up?

alquerci commented 5 years ago

@desyncr Nothing related directly to this PR but more about the status of @friendsofsymfony1 organisation.

See FriendsOfSymfony1/symfony1#201

cc @thePanz

desyncr commented 5 years ago

True. My bad. I could add a php version check at runtime to determine which one to use.

Maybe related: https://github.com/FriendsOfSymfony1/doctrine1/issues/66.

thePanz commented 5 years ago

@endelwar @desyncr I created https://github.com/FriendsOfSymfony1/doctrine1/pull/72 to support php 5.3 onwards