search

FriendsOfSymfony1 / doctrine1

[DEPRECATED -- Use Doctrine2 instead] Doctrine 1 Object Relational Mapper.
http://www.doctrine-project.org
GNU Lesser General Public License v2.1
40 stars 75 forks source link

php 8.2 support #91

Closed thirsch closed 1 year ago

thirsch commented 1 year ago

And here is the doctrine1 part of the 8.2 support.

For every missing property, I've tried to keep the style used in the surrounding classes. Some are written "each prop per line", others are separated by comma, as in sf1. My primary goal was to not change too much of existing things but make it compatible to 8.2.

Here is the 8.2 support branch for sf1: https://github.com/FriendsOfSymfony1/symfony1/pull/274

thirsch commented 1 year ago

Thanks!

  • would it be possible to keep the git commit messages consistent? (php 8.2 >)
  • Could you please rebase (merged another PR) again?

Sure, commit messages are fixed and branch is rebased.