FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
337 stars 175 forks source link

symfony 1.x forks: What is your opinion on security / vulnerabilites? #208

Closed klemens-u closed 4 months ago

klemens-u commented 5 years ago

Hi everybody,

first of all a big thank you to all who participate in keeping symfony 1.x alive and usable. I myself choose symfony1 as the foundation of a relatively large project in 2009. As you can imagine I was pretty speechless when support for symfony 1 was dropped only 3 years later.

Well, some of the installations of my project are still in use today, and it looks as they have to run a few more years.

My question for you is about your view on security and vulnerabilites. Symfony 1.4.20 was already pretty stable, but of course for such a complex software and evolving environments (databases, webservers, new attack vectors) some vulnerabilites are probably still hidden somewhere.

A member of the community recently gave me his opinion, that it would be negligently to still use sf1 because there must be "loads of vulnerabilites".

I looked through the commits on this repo and through punkave's fork, but I did not really find a lot of security related fixes.

Thanks a lot!

mkopinsky commented 5 years ago

We have had a penetration test conducted on our sf1 application (included manual as well as automated tools such as burp) and the issues discovered were all application issues (eg not properly escaping things for XSS) or server configuration things (CORS headers, ServerSignature apache config, that sort of thing).

This isn't to say that symfony1 doesn't have any issues - we don't use a lot of features such as auto escaping in templates, so those features may have holes. But I wouldn't say that using symfony1 is an unsafe choice.

Security vulnerabilities are not things that appear spontaneously. Symfony1 is not any less safe for its having sat for years without much development. Obviously you shouldn't be running it on CentOS 5, Apache 2.2, and PHP 5.3. But with the right surrounding pieces, I don't see any problem.

mentalstring commented 5 years ago

I agree that vulnerabilities don't just pop up because it isn't being actively developed; it is probably more relevant to make sure that the underlying stack (specially PHP) is up to date.

With that said, it's perhaps worth mentioning that a SQL injection bug was found on Propel about a year ago. I know the question is about symfony, but many sf1 projects use Propel.

hugochinchilla commented 4 years ago

We have also had a penetration test done against our application and the only issues were all our fault, nothing was because of the framework itself.

DavidGoodwin commented 4 years ago

Ditto external pentesting with a symfony 1.4 app (using this package) - which passed without issue.