FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
338 stars 176 forks source link

Add(cs-fixer) Add php-cs-fixer configs and github action #280

Closed thePanz closed 1 year ago

thePanz commented 1 year ago

Ref: https://github.com/FriendsOfSymfony1/symfony1/issues/276

thePanz commented 1 year ago

@thirsch

Just two thoughts about it: How about ending a file with line break and as the .php-cs-fixer.dist.php is included within it's own defined finder, should the detector in step 2 (Get Changed Files @ all) detect changes there as well?

I took the code from https://github.com/FriendsOfSymfony1/symfony1/issues/276 and just created a PR :) To answer your question @thirsch :

  1. yes, I would merge the two files in one, .php-cs-fixer.dist.php
  2. gitworkflow: I would keep it simple, and not early-optimize (keep the simple configuration as shown in: https://github.com/OskarStark/php-cs-fixer-ga#usage-with-cache )

For further iterations:

thePanz commented 1 year ago

@thirsch @connorhu I would close this PR and instead work on https://github.com/FriendsOfSymfony1/symfony1/pull/283 WDYT?