fix: avoid creating dynamic property $options

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support

https://symfony.com/legacy

MIT License

342 stars 177 forks source link

fix: avoid creating dynamic property $options #290

Closed vimar closed 1 year ago

vimar commented 1 year ago

Dynamic properties are deprecated since PHP8.2

vimar commented 1 year ago

Any idea when this PR will be merged into main branch? is @thePanz the only user allowed to review and merge it?

thePanz commented 1 year ago

Thanks for poking me @vimar , approved the PR, waiting for the CI to run!

update The CI is stuck somehow :shrug:

JohannesTyra commented 1 year ago

@thePanz Thx. Should we create a new realease? Or are other commits also waiting for merging into master?

thePanz commented 1 year ago

I have more changes in the pipelines, can not guarantee when they will land tho. I guess you can fix this commit on your SF 1.x project, and composer will let you know when the new release will appear @JohannesTyra