FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
338 stars 176 forks source link

fix: PHP warnings triggered by the test suite #302

Open alquerci opened 9 months ago

alquerci commented 9 months ago

The test should fail when a warning PHP error occurred.

Depends on

How to execute tests?

To make test passes, I apply the following dependencies:

Checkout the "bundle": https://github.com/alquerci/symfony1/tree/fixtest-fail-on-php-errors--dev

Then execute:

test/bin/test --dependency-preferences 'lowest highest'

What is done?

What about the CI?

I try to put a PHP error_reporting directive, but the execution environment looks like different than docker.

Next steps

alquerci commented 8 months ago

@thePanz hey, I got it tests passes on GitHub action.

Let me know whether this PR has any chance to be merged.