search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
338 stars 176 forks source link

minor fix: remove fourth argument #308

Closed connorhu closed 8 months ago

connorhu commented 8 months ago

There is no fourth argument. Nice catch phpstan!

thePanz commented 8 months ago

Thanks @connorhu!

Do we have a phpstan integration planned? that would be great to have it in the pipeline too IIRC the last time I tried to enable it, it crashed with some methods overrides where the return type changed from a value to an array

connorhu commented 8 months ago

@thePanz At this time we have 800+ errors at level 9 (Which seems a lot, but in a much smaller project I last found 3000). I can see the sense of making a distribution stan config, but running it in a workspace is yet too early. I plan to run it locally sometimes and fix any bugs that arise.

mentalstring commented 8 months ago

I had a go at some point and also hit some internal error crashes.

@connorhu Could you share here what phpstan version and config you are using?

connorhu commented 8 months ago

@mentalstring https://github.com/FriendsOfSymfony1/symfony1/compare/master...connorhu:symfony1:feature/stanconfig It needs work because it stops after 50 internal errors. Generated classes are missing.

connorhu commented 8 months ago

oh. 24658 errors if i setup properly. nice.