search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
337 stars 175 forks source link

Set min versions of swiftmailer to 5.4.13 and 6.2.5 and updated swiftmailer submodule #331

Closed thirsch closed 4 months ago

thirsch commented 4 months ago

@thePanz I've reverted my approach of removing the submodules, as our own tests here in the repo heavily rely on them. Composer autoloading is not implemented for them. Maybe we can tackle this issue in another pr, independent of the min version constraints?

connorhu commented 4 months ago

It would not be bad to get rid of the submodule system.

thePanz commented 4 months ago

@thePanz I've reverted my approach of removing the submodules, as our own tests here in the repo heavily rely on them. Composer autoloading is not implemented for them. Maybe we can tackle this issue in another pr, independent of the min version constraints?

Yeah, fine for me! Thanks for the PR

I will squash and merge it