search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
337 stars 175 forks source link

Refactor docker setup #339

Open thePanz opened 3 months ago

thePanz commented 3 months ago
connorhu commented 3 months ago

Refactor doker setup => Refactor docker setup

connorhu commented 3 months ago

Please update the README.md file too if anything changes.

thePanz commented 3 months ago

@connorhu @mentalstring I would need some help here: I did not setup any MySQL server and the tests are all green. Something is weird IMO

connorhu commented 3 months ago

@thePanz Anno I started looking at the possibility of psr-4 migration and even with obvious problems the test was green with lime. Then I began to port the test system to phpunit because I found lime to be totally unreliable. On topic: how can I help? Should I look at your branch?

mentalstring commented 3 months ago

@connorhu @mentalstring I would need some help here: I did not setup any MySQL server and the tests are all green. Something is weird IMO

Not sure if this is what you are referring to, but I think only unit/storage/sfMySQLStorageTest.php would use MySQL and it skips the test if the mysql extension is not installed. unit/storage/sfMySQLiStorageTest.php does the same if sqlite is not installed.

Currently, running tests with the symfony:test hides skipped tests behind a 'ok' which is how sfAPCCacheTest wasn't running on the CI for a long while due to test being skipped.

It also hides a bunch notices/warnings (e.g. try php unit/validator/sfValidatorSchemaTest.php). I think there is some work on https://github.com/FriendsOfSymfony1/symfony1/pull/302 that maybe helps with this, but I didn't look closely.

mentalstring commented 3 months ago

Speaking of tests and refactoring the docker setup, I think test/bin/test is no longer needed?