[i18n] sfMessageSource_MySQL is broken

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support

https://symfony.com/legacy

MIT License

337 stars 175 forks source link

[i18n] sfMessageSource_MySQL is broken #347

Open connorhu opened 3 months ago

connorhu commented 3 months ago

It uses mysql_ functions.

alquerci commented 2 months ago

Same issue for sfMySQLSessionStorage and its neighbour sfMySQLiDatabase, sfMySQLiSessionStorage.

php test/unit/storage/sfMySQLStorageTest.php

connorhu commented 2 months ago

That's why I don't like skipping tests. Status is green, but it's leaking blood.

alquerci commented 2 months ago

A small joke.

Lime is lying.

The main motivation for #301 is to convert lime to tell the truth. Actual behaviour it's surprising.