search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
337 stars 175 forks source link

[task] fix return statement missing stan errors #353

Closed connorhu closed 3 months ago

connorhu commented 3 months ago

issue #348

Here I'm not sure whether not to introduce constants like symfony/console does: https://github.com/symfony/symfony/blob/759b6e1126ed7a6bca6fe8f685bf47254aa82496/src/Symfony/Component/Console/Command/Command.php#L38-L40

thePanz commented 3 months ago

issue #348

Here I'm not sure whether not to introduce constants like symfony/console does: https://github.com/symfony/symfony/blob/759b6e1126ed7a6bca6fe8f685bf47254aa82496/src/Symfony/Component/Console/Command/Command.php#L38-L40

Maybe not now, we could do that with a rectorphp rule later on IMO

connorhu commented 3 months ago

@thePanz ok! I'll resolve the conflict and do a rebase.