search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
337 stars 175 forks source link

update SYMFONY_VERSION constant accordingly #354

Open verfriemelt-dot-org opened 3 months ago

verfriemelt-dot-org commented 3 months ago

heyho, just a minor nitpick, can you ensure to update the version defined here:

https://github.com/FriendsOfSymfony1/symfony1/blob/master/lib/autoload/sfCoreAutoload.class.php#L12

:) thx for you effort with this legacy codebase!

connorhu commented 3 months ago

Thank you for the reminder! We will add this step to the release process. Am I right @thePanz ? :) (Just for the sake of science: what if I make a GHA process that does the release process on tagging. Including version number setting? I wonder what that would look like.).

thePanz commented 3 months ago

Thank you for the reminder! We will add this step to the release process. Am I right @thePanz ? :) (Just for the sake of science: what if I make a GHA process that does the release process on tagging. Including version number setting? I wonder what that would look like.).

Having an automated tagging would be great, or a pipeline making sure that the tagging is correct. Never did that before tho

connorhu commented 3 months ago

@thePanz Sebastian has just done one of his projects. What do you think about such a solution? https://github.com/sebastianbergmann/foal/commit/b0e3537cfc444803ae3d977510172684db24b697