search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
338 stars 176 forks source link

update the SYMFONY_VERSION constant to the latest release number #355

Closed verfriemelt-dot-org closed 6 months ago

verfriemelt-dot-org commented 6 months ago

hi,

just a minor fix in context with #354

cheers :v:

thePanz commented 6 months ago

@connorhu @verfriemelt-dot-org it should be 1.5.20-dev, as 1.5.19 has been tagged few days ago :)

connorhu commented 6 months ago

@thePanz Are we here already? Time flies (and version numbers)

verfriemelt-dot-org commented 6 months ago

i updated it to 1.5.20 :) i think this was at some time done automatically via https://github.com/FriendsOfSymfony1/symfony1/blob/master/data/bin/release.php#L85 maybe a simple version file would be a simple solution.

something like this in the release pipeline:

$ git describe --tags > version

and just reading in that file from the lib-root instead of replacing that token in the php file. with that we could just leave the version at main or 1.5.x-dev :thinking:

thePanz commented 6 months ago

[...]with that we could just leave the version at main or 1.5.x-dev 🤔

Having '1.5.x-dev' would be nice, we might also want to rename the 'main' branch to be '1.5.x' too, to simplify the management of -dev aliases (loke we have I for swiftmailer)

Wdyt?