search

FriendsOfSymfony1 / symfony1

[DEPRECATED -- Use Symfony instead] Fork of symfony 1.4 with DIC, form enhancements, latest Swiftmailer, better performance, composer compatible and PHP 8 support
https://symfony.com/legacy
MIT License
338 stars 176 forks source link

Deprecated message in sfFormField #373

Closed DavidGoodwin closed 3 months ago

DavidGoodwin commented 3 months ago

Hi,

Optional parameter $parent declared before required parameter $value is implicitly treated as a required parameter in lib/form/sfFormField.class.php on line 44

https://github.com/FriendsOfSymfony1/symfony1/blob/998e779350347baf13a0809c38c3831de6bb41d8/lib/form/sfFormField.class.php#L44

I'm not sure what PHP's behavior is with this - should name+value be made optional, or should $parent not be optional?

Still it'd be nice to not see this being reported in our server logs ;-)

image

TIA

DavidGoodwin commented 3 months ago

erk , duplicate of https://github.com/FriendsOfSymfony1/symfony1/pull/365 ... ignore me.