search

FriendsOfTYPO3 / extension_builder

TYPO3 extension to kickstart and maintain TYPO3 extensions
https://docs.typo3.org/p/friendsoftypo3/extension-builder/11.0/en-us/
GNU General Public License v2.0
113 stars 80 forks source link

[BUG] 🐛 Roundtrip merge not working #736

Open discoebbe opened 4 months ago

discoebbe commented 4 months ago

Describe the bug When saving the extension custom methods inside existing models are deleted

To Reproduce

  1. Create a Model. Save it. Add custom methods.

  2. Configure overwriteSettings for Models like: overwriteSettings: Classes: Controller: merge Domain: Model: merge Repository: merge

  3. Open the Extension in Builder again and save it => all custom methods in the model class file are gone.

Expected behavior keep custom methods and only add setters and getters for new properties

TYPO3 Version 12.4.11

Extension Builder Version: 12.0.0-beta.1

discoebbe commented 4 months ago

Same wrong behavior for Controllers and Repositories

PKuhlmay commented 4 months ago

Thank you. I will have a look at it. If you know how to solve this, pull requests are welcome 😅

PKuhlmay commented 4 months ago

It seems it broke at commit 733e71cf8a31d84fd3be67bb17410f003348cc94