search

FriendsOfTYPO3 / extension_builder

TYPO3 extension to kickstart and maintain TYPO3 extensions
https://docs.typo3.org/p/friendsoftypo3/extension-builder/11.0/en-us/
GNU General Public License v2.0
113 stars 80 forks source link

Renew SPLIT_TOKEN #759

Open SSFGizmo opened 5 months ago

SSFGizmo commented 5 months ago

Can SPLIT_TOKEN be renewed in // EXTENSION BUILDER DEFAULTS END TOKEN ..., because the PHP-CS-Fixer with the default configuration constantly changes it to //# EXTENSION BUILDER DEFAULTS END TOKEN ...?

DavidBruchmann commented 5 months ago

Actually it'S defined differently, but // is probably better than ## https://github.com/FriendsOfTYPO3/extension_builder/blob/db6794dc28fb074d4dbd80b27b028c90ed0f0006/Classes/Service/RoundTrip.php#L47

Problem might be in yaml files perhaps, I don't know if comments are possible there with //

Whats you suggestion and reasoning?

DavidBruchmann commented 5 months ago

In PHP files some comments starting with # might be mistaken as annotation and lead to errors therefore. It depends on the context though.

DavidBruchmann commented 5 months ago

@PKuhlmay you think we can just change the token? Or we need to take care about compatibility to former created extensions somehow? I think the token could be used in yaml files too, is this compatible?

PKuhlmay commented 5 months ago

I don't know, honestly. We could change it and then test it with old extensions.