search

FriendsOfTYPO3 / frontend_editing

TYPO3 CMS Frontend Editing
https://friendsoftypo3.github.io/frontend_editing/
102 stars 39 forks source link

ContentObjectRenderer Xclass always set $editUid=1 for localized CE #693

Closed webian closed 1 year ago

webian commented 1 year ago

https://github.com/FriendsOfTYPO3/frontend_editing/blob/7c248c870bc2cf80a8d2041cdaf6e02f5c05f701/Classes/Xclass/ContentObject/ContentObjectRenderer.php#L54

If $dataArray['_LOCALIZED_UID'] is set, $editUid will always be 1 but should instead be the uid of the localized record.

The description of this commit https://github.com/FriendsOfTYPO3/frontend_editing/pull/579/commits/bbb805eea8c1eaec3065cc6ba8d890252a1e2224 is "[TASK] Add Xclass for handling PHP 8 in ContentObjectRenderer"

What's the purpose of this xclass @MattiasNilsson?

MattiasNilsson commented 1 year ago

@webian The whole purpose of the XCLASS was to add isset($dataArray['_LOCALIZED_UID']) for PHP8. It could be that the part is fixed in the core. Then that means that the XCLASS can be removed without any hassle.

webian commented 1 year ago

I opened a bug report in TYPO3 core https://forge.typo3.org/issues/101602

and made a PR to fix this bug.