FriendsOfTYPO3 / openid

Extends TYPO3 Authentication to allow OpenID 2.0
12 stars 15 forks source link

Add support for TYPO3 v10 #27

Closed dmitryd closed 4 years ago

dmitryd commented 4 years ago

This ticket is created to reference it in the pull request. Subject says it all.

dmitryd commented 4 years ago

Pull request: https://github.com/FriendsOfTYPO3/openid/pull/28

liayn commented 4 years ago

@dmitryd Are you satisfied with the current state of the extension for v10?

dmitryd commented 4 years ago

@liayn Do you know if it works with the new TYPO3 cookie policy?

liayn commented 4 years ago

I'm sorry, I don't know. See also https://github.com/FriendsOfTYPO3/openid/issues/29#issuecomment-610234042 please. If you are keen on maintaining the extension again, feel free and let me know.

dmitryd commented 4 years ago

@liayn I can take over. Hopefully I will have time this week to check with v10 but I think I will need to add a modification for TYPO3_CONF_VARS in the extension to let the ext work out of the box.

haassie commented 4 years ago

Hi @dmitryd and @liayn. We use this extension for all our installations and are working on v10 upgrades as well. Will ask my colleagues to test this patch.

liayn commented 4 years ago

@haassie No need to test this patch. All changes should already be in the master branch. Out of curiosity: Which provider do you use?

@dmitryd Okay. I'll then transfer the ext key in TER to you.

haassie commented 4 years ago

@liayn well, our main issue https://github.com/FriendsOfTYPO3/openid/blob/master/ext_tables.sql#L47 is still in Resulting in errors in our installations. See https://github.com/FriendsOfTYPO3/openid/issues/30.

We are using https://www.atlassian.com/nl/software/crowd since a long time for our authentication and use the Crowd OpenID server with that.

dmitryd commented 4 years ago

@haassie You can try 10.0.1

haassie commented 4 years ago

Thanks @dmitryd. Everything seems to work fine!