search

FriendsOfTYPO3 / tt_address

Add address / contact datasets to your content management system.
GNU General Public License v2.0
40 stars 76 forks source link

[FEATURE] Allow editors to maintain instagram profiles #444

Closed lukas-maxheim closed 2 years ago

lukas-maxheim commented 2 years ago

The feature adds an additional field to the address records to allow editors to maintain instagram profiles and integrate them on the website.

This also adds an updated version of the php cs-fixer configuration file to use the current stable version.

Checklist

-[x] Create a topic branch from where you want to base your work. -[x] Make commits of logical units. -[x] Use php-cs-fixer to make sure the code is formatted correctly. -[x] Make sure your commit messages are in the proper format. -[x] Make sure you have added the necessary tests for your changes. -[x] Run all the tests to assure nothing else was accidentally broken. However travis will do that for you as well.

georgringer commented 2 years ago

thanks for your PR, however I don't want to merge that as it is easy to add this field by 3rd party extension. no need to add every social tool to tt_address. regarding the phpcsfixer: I will switch to offical cgl testing of typo3 testing framework soon

lukas-maxheim commented 2 years ago

Alright, thank you for your feedback!