FriendsOfTYPO3 / tt_address

Add address / contact datasets to your content management system.
GNU General Public License v2.0
40 stars 76 forks source link

Error in TYPO 12.4.14 with console command #523

Closed kanow closed 7 months ago

kanow commented 7 months ago

Bug Report

Current Behavior Flush cache in cli shows an error:

PHP Fatal error: Declaration of FriendsOfTYPO3\TtAddress\Command\GeocodeCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /app/vendor/friendsoftypo3/tt-address/Classes/Command/GeocodeCommand.php on line 47

Expected behavior/output No error and "Cache flushed" message

Environment

Possible Solution Can be fixed in line 47 of FriendsOfTYPO3\TtAddress\Command\GeocodeCommand.php

just adding that missing : int

protected function execute(InputInterface $input, OutputInterface $output): int

kanow commented 7 months ago

Ah, I see it's already fixed in the master branch. Is fixed in version 8.x. Maybe also version 7.x can be fixed? It seems to me that dependencies are not correct in that version.

georgringer commented 7 months ago

I don't plan to support the 7.x branch, just patch it yourself or update

kanow commented 7 months ago

Ok, did it.