Closed mlsuh closed 5 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
e62374b
) 98.81% compared to head (5795b41
) 98.27%.
Files | Patch % | Lines |
---|---|---|
src/simulations/montecarlo.jl | 86.95% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on the feedback from the QMC.jl devs we need to restrict lattice rules to shifting and allows scrambling only for digital nets (sobol, faure (to be added)).
Then we should contribute the rhalton
sampling to the QMC package to allow for scrambled halton sequences. https://arxiv.org/pdf/1706.02808.pdf
Using methods from QuasiMonteCarlo.jl
Closes #144.