FriesischScott / UncertaintyQuantification.jl

Uncertainty Quantification in Julia
MIT License
28 stars 7 forks source link

Include build scripts for c++ solvers in tests #150

Closed AnderGray closed 5 months ago

AnderGray commented 5 months ago

Package was failing when testing on my HPC machine, and getting a confusing error from Julia.

Eventually found it was the c++ external solvers used in some of the tests

i.e this one: https://github.com/FriesischScott/UncertaintyQuantification.jl/blob/e62374b006d449b8e8b5a0a4aa0fc4a356d6da57/test/solvers/src/radius.c#L1

Perhaps it's worth including little build script for these c++ external solvers, and printing a custom error message in the case that these tests fail.

FriesischScott commented 5 months ago

Hey, thanks for reporting this. I think it would be good to potential move away from these compiled solvers. I see two potential solutions:

Any preferences?

AnderGray commented 5 months ago

I find the 100% Julia solution to be the cleanest, unless it defeats the purpose of the external model test?

FriesischScott commented 5 months ago

As long as I call it as a separate process it should't be a problem. I'll see what can be done.