search

FriesischScott / UncertaintyQuantification.jl

Uncertainty Quantification in Julia
MIT License
28 stars 7 forks source link

Drop dependency on HaltonSequence #56

Closed Gopal1259 closed 2 years ago

Gopal1259 commented 2 years ago

The dependency on the HaltonSequence is dropped. The code uses LowDiscrepancySample to calculate sample using HaltonSampling. The code has been modified to calculate the prime number required for HaltonSampling, the algorithm of the code is based on the idea of Sieve of Eratosthenes.

FriesischScott commented 2 years ago

First of all, this doesn't run. The test actions fail immediately because it doesn't precompile. Did you even try running the code yourself?

It also looks like you just changed the file online using the Github editor. I need you to learn how to use git using a GUI or the command line, whichever you prefer. And commit/push your changes from there. Anything else is not a sustainable workflow.

The update to the Project.toml with the dependency removed is missing as well.

You can run the tests locally using test after switching to pkg with ].

FriesischScott commented 2 years ago

Regarding the coprimes: There is a lot of discussion going on in Primes.jl. I think the best way for now would be to just use the nextprime function from Primes.jl and wait for them to improve on it. It's not very efficient, but simple to implement and I don't see anyone using halton sampling in really high dimensions.

Gopal1259 commented 2 years ago

Good Morning Sir, Yes, I have tried running the code as a separate function on my system and it was running perfectly fine. I am sorry, if I have changed anything important, I will spend more time today learning Git and will also try to implement the code using primes.jl. If it is possible, can I have a meeting with you tomorrow, to understand the error.

Regards, Gopal Agarwal

On Wed, Jan 5, 2022 at 1:06 PM Jasper Behrensdorf @.***> wrote:

First of all, this doesn't run. The test actions fail immediately because it doesn't precompile. Did you even try running the code yourself?

It also looks like you just changed the file online using the Github editor. I need you to learn how to use git using a GUI or the command line, whichever you prefer. And commit/push your changes from there. Anything else is not a sustainable workflow.

The update to the Project.toml with the dependency removed is missing as well.

You can run the tests locally using test after switching to pkg with ].

— Reply to this email directly, view it on GitHub https://github.com/FriesischScott/UncertaintyQuantification.jl/pull/56#issuecomment-1005628699, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXWR7IUBNJHDP7VZO3JFU3UUQX23ANCNFSM5LEDFTQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.*** com>

FriesischScott commented 2 years ago

Good Morning Sir, Yes, I have tried running the code as a separate function on my system and it was running perfectly fine. I am sorry, if I have changed anything important, I will spend more time today learning Git and will also try to implement the code using primes.jl. If it is possible, can I have a meeting with you tomorrow, to understand the error. Regards, Gopal Agarwal

No need to be so formal on here :). Just send me an email with a time that works for you and we can meet online.

FriesischScott commented 2 years ago

Sir, I would be comfortable meeting you at 3pm tomorrow. Does it work for you? Regards, Gopal Agarwal

Not an email, but 3pm tomorrow works.