search

Frinn38 / Custom-Machinery

A Minecraft Mod about creating cutom machines that works
GNU Lesser General Public License v3.0
45 stars 17 forks source link

Outputs to incorrect slot when multiple outputs are used. #37

Closed NihilEntropy closed 2 years ago

NihilEntropy commented 2 years ago

Machine json: https://pastebin.com/wCJwUR9K Machine Recipe json: https://pastebin.com/McXuMpuS

No errors in custommachine log, other recipes work just fine. The JEI shows it outputing to the wrong slot as-well, even with different names, and switching mode to both, except for the slot which it uses as the input slot, then it goes there. If I blacklist the items in the other slot, the output doesn't appear, and it eats the item.

If I have any typos in the code, I apologize in advanced, but I tried my hardest to find what I did wrong, and I can't.

Frinn38 commented 2 years ago

Your machines and recipe are fine, there is a bug in the jei integration for the current version. The bug is already fixed in dev, I just didn't push an update since the fix was made. Closing as there is already an issue opened for this bug.

NihilEntropy commented 2 years ago

Your machines and recipe are fine, there is a bug in the jei integration for the current version. The bug is already fixed in dev, I just didn't push an update since the fix was made. Closing as there is already an issue opened for this bug.

What version should I expect the fix for this, as it still appears to be present in the latest custommachinery-1.16.5-0.5.6.jar?

NihilEntropy commented 2 years ago

I don't think it is the JEI integration, as it mechanically isn't doing what it should. It is as though only one output slot is cared about, and universally prioritized, even when a recipe specifies a different slot.

image image image image Notice, two different outputs, one bucketoutslot, the other is outslot. bucketoutslot is specified in recipe for the output, yet outslot is used. image Further confirmation here, as bucketoutslot is located directly below the bucketslot.

Frinn38 commented 2 years ago

A ok I misunderstood the issue here. I will do some testing to see why the item recipe requirement doesn't respect the "slot"property.

NihilEntropy commented 2 years ago

A ok I misunderstood the issue here. I will do some testing to see why the item recipe requirement doesn't respect the "slot"property.

Hmm, I just realized this might affect multi-outputs if you have more than one output slots with different names but all usable for an output. Maybe it needs to have a list involved, like "slots" : ["outslot1", "outslot2"] and a slot whitelist bool.

Frinn38 commented 2 years ago

Fixed in 0.5.8