search

Fris0uman / CDDA-Game-Launcher

A Cataclysm: Dark Days Ahead launcher
MIT License
58 stars 2 forks source link

Backups don't work. #56

Open Terrorforge opened 1 year ago

Terrorforge commented 1 year ago

Describe the bug Once my save directory grows larger than ~50mb, backups stop working. The client just crashes, and the backup doesn't work. It shows in the "Backups" tab, but it has 0 world, 0 characters and is 0b large.

e: I thought it was backing up successfully before this and it just wasn't showing up in the "Backups" tab, but looking at the actual files they all seem to be broken or empty anyway

To Reproduce Have a larger-than-absolutely-minimum save game and attempt to create a backup.

Expected behavior Backups complete successfully and the launcher doesn't crash.

Screenshots image This is what it looks like after a few of these failed backups.

Desktop (please complete the following information):

Additional context This has been a problem since at least the DazedNConfused version, but apparently it persists.

Fris0uman commented 1 year ago

So far 50mb backups fine image 100mb also works image

I'll need more info in order to repoduce the crash I guess

Terrorforge commented 1 year ago

It's definitely inconsistent. I just tried doing a manual backup on a save that's 82.6MB. The first time, it crashed, and the archive showed up in the "Backups" tab as having 0 "Actual size". Opening the archive with WinRAR throws an "Unexpected end of rachive" error. Did it a couple more times and it seems to be even odds if it crashes or not.

The second time, it seemingly completed. The archive was created and doesn't throw any errors when I open it in WinRAR. However, it doesn't show up in the "Backups" tab at all.

I guess just try backing up a few times in a row and see if it breaks? If that doesn't work, I remember that it used to get worse and worse as the saves grew larger. At a few hundred MB, it would still back up successfully sometimes, but as the size climbed into the gigbytes it hit a point where it never, ever worked. Unfortunately I just lost all my large, long-term saves due to a computer mishap, so I can't test this at the moment. But if/when you happen to have a large save laying around, I guess throw it in there and see if it breaks?

Fris0uman commented 1 year ago

Do you get any error message with the crash?

Terrorforge commented 1 year ago

Nope. It just closes silently.

DazedNConfused- commented 1 year ago

Sounds awfully similar to what I have personally experienced in https://github.com/DazedNConfused-/CDDA-Game-Launcher/issues/9

Unfortunately the "fix" I came up with isn't pretty at all. Maybe you will have better luck tackling this one

c0bnut commented 1 year ago

Auto backups not working for me, and when clicking "Backup current saves" it says Saves backup completed but doesn't show anything in the list. Even after refreshing the list. My save folder is only 7 MB. Moving back to the Catapult launcher until this is fixed, pretty bad not being able to backup saves in experimental.

c0bnut commented 1 year ago

42

JReese3 commented 1 year ago

image Similar issue but not consistent, I do get a silent crash when it fails.

JReese3 commented 1 year ago

How people have small saves alludes me. A two season run with 1 character can easily exceed 100MB.

DazedNConfused- commented 1 year ago

image Similar issue but not consistent, I do get a silent crash when it fails.

This was exactly my biggest gripe when I had originally forked the launcher back on Remy's latest version. My (non) fix was https://github.com/DazedNConfused-/CDDA-Game-Launcher/commit/f7163a77464b82b2c7886af4a579b2f37669a901 . I hadn't experienced a crash ever since - or at least I didn't while I was still using Windows