search

Frititati / CI_2022_292113

The public repo for all Course Work done over the Computatation Intelligence Course 01URROV POLITO
0 stars 0 forks source link

Lab1 Peer Review #1

Open AlessiaLeclercq opened 2 years ago

AlessiaLeclercq commented 2 years ago
  1. Yanking without citing Prof. Squillero is missing in README.md (Priority Queue implementation, 8-puzzle notebook)
  2. In goal_test() function, instead of using a nested for loop, use set.update() method for sets for better readability
  3. Define variable type in all functions, it makes code readability easier
  4. In priority_function_astar_with_state_cost1() new_list is not defined
  5. In the priority functions: notation new_list for a set + len(range(N)) is N - usefulness computations are performed
  6. Instead of using lists use np.array for efficiency purposes: python lists are heterogeneous and non-contiguous in memory, whereas np.arrays are homogeneous and contiguous + numpy package can parallelize computations
Frititati commented 2 years ago

Thank you for the review, I have already corrected the Sources, I have forgotten to add them to the README.md. For everything else I will take your advice and see what improvements I can make. Thanks again!