FrittenKeeZ / laravel-vouchers

Voucher system for Laravel 9+
MIT License
55 stars 15 forks source link

Roadmap #5

Open FrittenKeeZ opened 4 years ago

FrittenKeeZ commented 4 years ago

0.1.x - 0.2.0

>0.2.x

>1.x

zaghadon commented 2 years ago

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

FrittenKeeZ commented 2 years ago

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

Only that it's shorter and simpler - regardless it would be a breaking change and a major dev version if I do, but I'm aiming to do it for 1.0.0

zaghadon commented 2 years ago

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

FrittenKeeZ commented 2 years ago

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

I don't really have any other noteworthy packages, but I would change the namespace across the board, yes.

zaghadon commented 2 years ago

Ohh, okay. That's justifiable.

Hopefully this would be effectively documented. Let me know when you want to make this change so I could help implement and document it.

mgamal92 commented 1 year ago

@FrittenKeeZ Are you still working on open tasks ?

FrittenKeeZ commented 1 year ago

@mgamal92 I want to get back and update this for Laravel 10 and probably remove Laravel 5 in the process - there's been a lot of other projects taking my time, but I want to progress this one soon, and Laravel 10 is a good excuse :)

mgamal92 commented 1 year ago

@FrittenKeeZ May I help you in this package and work on some tasks ? so we can arrange that between us

FrittenKeeZ commented 1 year ago

@mgamal92 Sure, just open a PR

mgamal92 commented 1 year ago

@FrittenKeeZ Sure but are there some tasks which have more priority ?

FrittenKeeZ commented 1 year ago

@mgamal92 I've just updated the roadmap, but you can just choose what you feel like

mgamal92 commented 1 year ago

@FrittenKeeZ OK great

addgod commented 1 year ago

I would consider changing the "withEntities" to take a collection or array of entities. This would make it much easier to use programmatically, when you chain the facade.

Also it would be great if the withStartTime would take a null as well, so you do not have to wrap it in a if sentence first to make sure it exists, if you are generating these from some user input. Same with withEndTime.

jn-devops commented 4 months ago

Will there be an update to support the latest Laravel framework e.g. 11.10.0?

FrittenKeeZ commented 4 months ago

@jn-devops yes, I've thought about removing support for everything below Laravel 9 and update tests accordingly