FritzAndFriends / BlazorWebFormsComponents

A collection of Blazor components that emulate the ASP.NET Web Forms controls of the same name
MIT License
429 stars 72 forks source link

AdRotator DataBinding features #210

Open csharpfritz opened 4 years ago

csharpfritz commented 4 years ago

AdRotator needs to support the DataBinding features like:

hishamco commented 4 years ago

I can work on this one ...

csharpfritz commented 4 years ago

You got it @hishamco !

hishamco commented 4 years ago

@csharpfritz is there ability to edit your first thread so I can check the one that have been done while I'm working on

hishamco commented 4 years ago

I finished from the last 4 features, I will create another PR for DataBinding later on ...

hishamco commented 4 years ago

Just thinking about DataSource I think we should do similar to what we did when we bound DataTable to GridView. Regarding DataMember I don't think I used in the past so your thought @csharpfritz?

hishamco commented 4 years ago

@csharpfritz I start work to make AdRotator a DataBoundCompoment but the issue is both DataSource and DataMember are associate with DataSource controls in ASP.NET, so mark them as Obsolete may a better choice unless we need to bind it with DataTable but this need some efforts to map table columns to AdRotator properties

Your thoughts?

csharpfritz commented 4 years ago

DataSourceID is used with DataSource controls in ASP.NET. DataSource and DataMember work with code-behind and DataBinding. Let's NOT mark those as Obsolete.

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

hishamco commented 4 years ago

DataSourceID is used with DataSource controls in ASP.NET.

Oops, just forgot that one ;)

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

Sounds good, but the issue here is based on the convention to map the AdRotator properties